chore: update snippets for Maps 3D SDK compatibility#25
Conversation
|
Not attributable to this PR, but we could think of modularising all individual projects, to make mainteinance easier. |
| google() | ||
| mavenCentral() | ||
| maven { | ||
| url = uri("/Users/dkhawk/AndroidStudioProjects/github-maps-code/android-maps3d-samples/feat-update-library-version/local-maven-repo") |
There was a problem hiding this comment.
We would need to remove this or use a different placeholder before merging it, right?
CATALOG.md
Outdated
| @@ -0,0 +1,1033 @@ | |||
| # Snippets Catalog | |||
There was a problem hiding this comment.
Should this file go inside the snippets folder?
| ) | ||
| } | ||
|
|
||
| private fun configureMap(map: GoogleMap3D) { |
There was a problem hiding this comment.
Do we need any configuration here?
snippets/catalog_generator.py
Outdated
| content_lines = [] | ||
| valid_line = True | ||
| if tag == "maps_android_3d_camera_events_java": | ||
| print(f"DEBUG: Processing {tag}. Total lines captured: {len(snippet_data['lines'])}") |
There was a problem hiding this comment.
nit: this debug statements can be configured with Python built-in logging module.
| roll = 0.0 | ||
| range = 2000.0 | ||
| } | ||
| // LINT.ThenChange(//depot/google3/java/com/google/android/gmscore/integ/testapps/maps3d/basic/res/layout/main.xml) |
There was a problem hiding this comment.
This probably needs to be removed before merging, right?
| // LINT.ThenChange(//depot/google3/java/com/google/android/gmscore/integ/testapps/maps3d/basic/res/layout/main.xml) | ||
|
|
||
| flyToButton.setOnClickListener { | ||
| Log.d("MainActivity", "flyToButton clicked") |
There was a problem hiding this comment.
What about adding a TAG for all these logs?
dkhawk
force-pushed
the
feat/snippets-updates
branch
from
c252aa4 to
6ea5a76
Compare
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
3 participants
Updates snippets to be compatible with Maps 3D SDK v0.2.0.
Changes:
positiontopositionAnchorin Popover.autoCloseEnabledandautoPanEnabledproperty names.